Error when building with `electron@9.3.0`

Meeting SDK Electron
1

Description
When I run a build script for mac with globally installed electron@9.3.0 get an error.

Here is a part of a log with the error.

../lib/node_add_on/mac/../zoom_sinks_wrap_class.h:207:3: warning: ignoring return value of function declared with 'warn_unused_result'
      attribute [-Wunused-result]
                fn->Call(context, global, argc, argv);
                ^~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/node_add_on/mac/../zoom_sinks_wrap_class.h:233:60: error: too few arguments to function call, single argument 'isolate' was not
      specified
                bHandled = bReturnedValue.ToLocalChecked()->BooleanValue();
                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/mykola.ishchuk/Library/Caches/node-gyp/9.3.0/include/node/v8.h:2852:3: note: 'BooleanValue' declared here
  bool BooleanValue(Isolate* isolate) const;
  ^

Which version?
zoom-sdk-electron v5.0.24433.061
node v12.18.3
electron@9.3.0
node-gyp@7.1.0
bindings@1.5.0
MacOS 10.15.6

To Reproduce(If applicable)

  • npm i -g electron@9.3.0
  • sh build_nodeaddon_mac.sh

Additional context
I’ve checked with different versions of electron. Got next results:

  • electron@9.3.0 - failed with the mentioned error
  • electron@10.1.1 - the same error
  • electron@8.5.1 - success
  • electron@7.3.3 - success
  • electron@5.0.2 - success

Is version 9 of electron supported? Do you have any ETA when it will be supported?
Thank you in advance

2

Hi @iMykola,

Thanks for the post and pardon the late response. Currently our Electron SDK does not support Electron 9.3.0 and above. I have forwarded this as a feature request to the engineering team and they will investigate the possibility of supporting the newer version.

Thanks!

1 Like